Update dependencies #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lcsmuller
requested review from
barbieri,
victor-accarini,
leferlin,
oliveirarleo,
DDDKnightmare,
viniciuslacerda0,
gabriel4k2,
g7fernandes,
Dorkt,
LucasSantos27,
QSRafael,
brunorosano and
Gonzagadavid
lcsmuller
force-pushed
the
chore/update-deps
branch
from
97d3f90 to
18e3024
Compare
lcsmuller
force-pushed
the
chore/update-deps
branch
2 times, most recently
from
cb0bb34 to
902b01c
Compare
@victor-accarini Done! |
lcsmuller
force-pushed
the
chore/update-deps
branch
from
902b01c to
bc03b21
Compare
victor-accarini
previously approved these changes
May 11, 2023
lcsmuller
force-pushed
the
chore/update-deps
branch
from
bc03b21 to
f9a4beb
Compare
lcsmuller
force-pushed
the
chore/update-deps
branch
from
f9a4beb to
9d4eebc
Compare
lcsmuller
force-pushed
the
chore/update-deps
branch
from
9d4eebc to
2829f8f
Compare
lcsmuller
force-pushed
the
chore/update-deps
branch
from
2829f8f to
e25930f
Compare
lcsmuller
force-pushed
the
chore/update-deps
branch
from
e25930f to
199ce0d
Compare
lib/parse.ts
Outdated
Comment on lines
55
to
56
| // we already checked for not undefined, but TS doesn't get it :-( | ||
| ((customize && customize[key]) as EnvSchemaParserFn<S, K>) || |
There was a problem hiding this comment.
I think we can remove this comment and assertion. After updating typescript, this shouldn't occur anymore.
Suggested change
| // we already checked for not undefined, but TS doesn't get it :-( | |
| ((customize && customize[key]) as EnvSchemaParserFn<S, K>) || | |
| (customize && customize[key]) || |
lcsmuller
force-pushed
the
chore/update-deps
branch
from
199ce0d to
a9f3ffa
Compare
lcsmuller
force-pushed
the
chore/update-deps
branch
from
a9f3ffa to
f8aa8ae
Compare
DDDKnightmare
previously approved these changes
May 24, 2023
Update dependencies to latest, fix typing
- Update linter-staged rules to auto-fix the code
lcsmuller
force-pushed
the
chore/update-deps
branch
from
f8aa8ae to
acef2f8
Compare
DDDKnightmare
approved these changes
May 24, 2023
oliveirarleo
approved these changes
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
Part of #2
How to test it
yarn lintyarn test