feat: create endpoint that return tree details #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfjnascimento
changed the title
lfjnascimento
force-pushed
the
feat/endpoint_builds
branch
from
84b80af to
48f6dd8
Compare
lfjnascimento
force-pushed
the
feat/endpoint_builds
branch
from
48f6dd8 to
527de46
Compare
viniciuslacerda0
approved these changes
Jul 15, 2024
mari1912
reviewed
Jul 15, 2024
There was a problem hiding this comment.
I'm not sure test_status is working properly, it returns 0 for all of them when I tested it for http://localhost:8000/api/tree/189ee9735a4b2e8095b1a6c088ebc8e133872471 for example. When I search only localhost:8000/api/tree it gets some tests for this commit hash. Here I'm using kcidb to test. It may be a good idea to change it to default
backend/kernelCI_app/serializers.py
Outdated
| start_time = serializers.CharField() | ||
| duration = serializers.CharField() | ||
| compiler = serializers.CharField() | ||
| test_status = serializers.CharField() |
There was a problem hiding this comment.
we will also need the link of logs
There was a problem hiding this comment.
You can test if there is a test.status for a specific build by runing:
SELECT tests.status
FROM
tests
WHERE tests.build_id = <build_id>You'll notice that most of the build you test there a test
mari1912
reviewed
Jul 15, 2024
lfjnascimento
force-pushed
the
feat/endpoint_builds
branch
2 times, most recently
from
81c10e4 to
2410e1f
Compare
mari1912
approved these changes
Jul 15, 2024
lfjnascimento
force-pushed
the
feat/endpoint_builds
branch
from
2410e1f to
06b8991
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
create an
tree/<str:commit_hash>endpoint that returns all builds and a summaryTo test it you can:
poetry python manage.py runserverhttp://localhost:8000/api/tree/22a40d14b572deb80c0648557f4bd502d7e83826