Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: build errors in accordion #119

Merged
merged 2 commits into from
Jul 19, 2024
Merged

fix: build errors in accordion #119

merged 2 commits into from
Jul 19, 2024

Conversation

mari1912
Copy link
Collaborator

@mari1912 mari1912 commented Jul 19, 2024 •
edited
Loading

  • change test errors for valid or invalid
  • make accordion count right

Related issues

@mari1912
fix: build errors in accordion
8d356cb 
- change test errors for valid or invalid
@mari1912 mari1912 requested a review from lfjnascimento July 19, 2024 19:20
@mari1912 mari1912 self-assigned this Jul 19, 2024
@mari1912
fix: build selector
a39779b 
- make it count from filtered items, not all accordion items
@mari1912 mari1912 merged commit e677e4c into main Jul 19, 2024
4 checks passed
@mari1912 mari1912 deleted the fix/build-errors-accordion branch July 19, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfjnascimento lfjnascimento lfjnascimento approved these changes

Assignees

@mari1912 mari1912

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Builds selector is not working correctly [Bug] Build errors in accordion
2 participants
@mari1912 @lfjnascimento