New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix "magic return value" of map_args_to_config #81

Open

1gintonic wants to merge 1 commit into prof79:main from 1gintonic:58_dynamic_download_mode

Contributor

1gintonic commented Jul 5, 2024

Removes "magic return value" of map_args_to_config and adds config attribute instead. Mentioned in #60

I'll accept though I'm not so happy with the single "magic return value" of map_args_to_config; the intuition returning a bool would be "did the mapping fail or not?". For me, a later fix would be to move that into the config class maybe even as a computed property (method),


          remove "magic return value" of map_args_to_config, add config attribute

b8dc87c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet