Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video hashing for v0.7.* compatibility should be improved #13

Open
prof79 opened this issue Feb 2, 2024 · 0 comments
Open

Video hashing for v0.7.* compatibility should be improved #13

prof79 opened this issue Feb 2, 2024 · 0 comments
Assignees
Labels
improvement Improve robustness & error handling

Comments

@prof79
Copy link
Owner

prof79 commented Feb 2, 2024

Bug Description

Video hashing should be improved so identical videos downloaded with v0.7.* and v0.8.2+ also hash the same. That was the original intention but I botched it.

Actual behavior

Downloaded videos may hash differently although they are the same from a content perspective.

Environment Information

  • Operating System: all
  • Fansly Downloader Version: v0.8.2, v0.8.3
  • Fansly Downloader Type: all
  • Specific creators name: all

Impact

Duplicate videos might get downloaded.

Additional context

Getting hold of ISO MPEG-4 Part 12 and 14 standards would be very helpful.
mdat parts that are identical should be singled out and the rest ignored, trak parts should be analyzed for pointers.
Directory with some useful documents added.

@prof79 prof79 self-assigned this Feb 2, 2024
@prof79 prof79 added the enhancement New feature or request label Feb 2, 2024
@prof79 prof79 changed the title Video hashing should be improved Video hashing for v0.7.* compatibility should be improved Feb 2, 2024
@prof79 prof79 added improvement Improve robustness & error handling and removed enhancement New feature or request labels Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improve robustness & error handling
Projects
None yet
Development

No branches or pull requests

1 participant