Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Video hashing is broken/identical for almost all files #12

Closed
prof79 opened this issue Feb 2, 2024 · 1 comment
Closed

Video hashing is broken/identical for almost all files #12

prof79 opened this issue Feb 2, 2024 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@prof79
Copy link
Owner

prof79 commented Feb 2, 2024

Bug Description

Almost all videos hash the same.

Expected behavior

Videos should hash differently in general but identical videos downloaded by old and new M3U8 processing should hash the same.

Actual behavior

Almost all videos hash the same.

Environment Information

  • Operating System: all
  • Fansly Downloader Version: v0.8.0-v0.8.1
  • Fansly Downloader Type: all
  • Specific creators name: all
  • Preliminary fix in: v0.8.2

Impact

More graving than thought at first glance. Will prevent downloading of new videos.

Additional context

Excluding the mdat box as a whole was a silly move under time pressure.
Getting hold of ISO MPEG-4 Part 12 and 14 standards would be very helpful.

@prof79 prof79 self-assigned this Feb 2, 2024
@prof79 prof79 added the bug Something isn't working label Feb 2, 2024
@prof79
Copy link
Owner Author

prof79 commented Feb 2, 2024

Partially, the most graving part at least, is fixed with https://github.com/prof79/fansly-downloader-ng/releases/tag/v0.8.2 . Duplicates may happen between v0.7.* and v0.8.2 and are tracked in a new issue under #13.

@prof79 prof79 closed this as completed Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant