-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix filterInteractions to be more general #2014
Conversation
Originally, we have filterInteractions and getInteractions using either kwargs selection alone, which is just based on residue numbers and names without chain ID, or both kwargs selection and selection2 that must both have chain IDs and don't take any other information. As such, the standard way to analyse interactions between two regions at present is to make them have separate chain IDs. With the old code, this is the procedure and the results we get for mGluR1 closed chain (1ewkA modified for comparison to 1ewkB in http://www.bahargroup.org/prody/tutorials/clustenmd_tutorial/clustenmd_tutorial_files.zip):
With the updated code, we can still reproduce these results:
We can also get them more easily as follows:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested. Works fine. Thank you, James.
So far, I just have a fix to the single selection mode, which didn't include chain, but I'm close to making the whole thing more general too.