Less ambiguous selection when building biomolecule #1758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a protein has a chain 'x' and a chain '2' and the x happens to be next to the 2 in the selection string (chain a b c x 2) the parser fails to realize that x and 2 are chain identifiers. This makes sure there is no ambiguity. There is still a problem with PDBs that have a chain 'bb' (e.g. 2VVJ), but I'm not up for diving into the parser to fix that.
Correctly parse biotransform header and include mutiple assemblies if present. Some tweaks to the atom parser for efficiency.
|
Any chance of a merge @jamesmkrieger ? |
|
ok. I'm not sure why it works, but I've made a pdb file with a chain x and it works, so yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a protein has a chain 'x' and a chain '2' and the x happens to be
next to the 2 in the selection string (chain a b c x 2) the parser fails
to realize that x and 2 are chain identifiers. This makes sure there is
no ambiguity.
There is still a problem with PDBs that have a chain 'bb' (e.g. 2VVJ),
but I'm not up for diving into the parser to fix that.