Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure PDB chain id is only a single character. #1757

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

dkoes
Copy link
Collaborator

@dkoes dkoes commented Oct 4, 2023

Some structures can have multi-character chain identifiers (see 6Z4H). Really Bad Things happen when trying to write these out.

dkoes added 2 commits October 3, 2023 20:46
Some structures can have multi-character chain identifiers (see 6Z4H).
Really Bad Things happen when trying to write these out.
@jamesmkrieger
Copy link
Contributor

Have you seen #1747? Do you think that works too?

@dkoes
Copy link
Collaborator Author

dkoes commented Oct 4, 2023

#1747 is only for reading files. This fix is for writing. You can't parse the 6Z4H PDB file because it doesn't exist - it is only available as mmCIF or mmtf. If you read it in as an MMTF, the chain ids are set to a three character string and the string formatting to write out the chain id can't handle this, resulting in the rest of the pdb line being displaced and values in the wrong fields.

@jamesmkrieger
Copy link
Contributor

ah, ok. Thanks

@jamesmkrieger jamesmkrieger merged commit 5e3bae4 into prody:master Oct 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants