-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MMTF Parser #1752
MMTF Parser #1752
Conversation
Thanks. Can you add a test for this too, please |
Added ImportError to except block for import mmtf.
Removed hard dependency for mmtf-python
Need to add from . import mmtffile
from .mmtffile import *
__all__.extend(mmtffile.__all__) to __all__ = ['parseMMTF'] to |
Multi model still doesn't work
Plus more tests
Support for bonds, test cases, other fixes.
At least as long is they are all the same molecule.
Support multi-model files.
Test and fixes added. |
ok, it's working now. I would prefer a pip install in main.yml but I guess it's not that heavy a dependency so it's fine. The last thing then is to give the user-facing function(s) a doc string. Thanks again for contributing this! |
I think this is ready to be merged. Vratin still needs to add a section to the tutorial on how to use this to parse the entire PDB in a few minutes using pyspark and MMTF, but that is a different repository. |
No, I think there are still a few last things to fix:
Besides that, yes, it sounds good |
Thanks! Very almost there now |
Could you let me know what further formatting you'd like to the docstring? I'll make the changes asap. |
Doc string is fine. the last thing is for the try/except to raise ImportError |
Looks good now. Thanks again! and thanks, David, for other fixes too! |
|
||
:arg title: Title to assign to the resulting AtomGroup. If not provided, the | ||
title is extracted from the MMTF structure or set to the PDB ID. | ||
:type title: str, optional |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
optional isn't really part of the type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally this should change but it’s ok really
Added a basic parser that can read in either an mmtf file or a mmtf structure (decoder) object into an atom group. Includes header retrieval for biomolecule building.