Throw if top-level repo name does not match PR base context #15
+71
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klutchell
force-pushed
the
kyle/throw-unexpected-repo-value
branch
3 times, most recently
from
6b3ace2
to
26d195e
Compare
klutchell
force-pushed
the
kyle/throw-unexpected-repo-value
branch
2 times, most recently
from
a2936b3
to
9cddddf
Compare
It is unclear from the docs whether the top level context.repo property will always reflect the target/base of a PR from a fork, or the forked repo. So to be safe until we can test all scenarios, throw an exception if the values do not match. Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/throw-unexpected-repo-value
branch
from
9cddddf
to
da5f96e
Compare
Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/throw-unexpected-repo-value
branch
from
da5f96e
to
11e4181
Compare
|
A repository maintainer needs to approve the commit(s) for this workflow. |
ab77
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is unclear from the docs whether the top level context.repo property will always reflect the target/base of a PR from a fork, or the forked repo.
So to be safe until we can test all scenarios, throw an exception if the values do not match.
Change-type: patch