Fix disptach method problem #38
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxrcx
commented
Jun 25, 2023
src/pyicu/tbl_utils.py
Outdated
| def dur_unit(x): | ||
| return dur_col(x).units # Changed from units(dur_col(x)) | ||
|
|
||
| @singledispatch |
There was a problem hiding this comment.
This doesn't choose the correct case
src/pyicu/tbl_utils.py
Outdated
| from pyicu.utils_cli import warn_dots | ||
| from functools import singledispatch | ||
|
|
||
| @singledispatch |
There was a problem hiding this comment.
if the default method is included it chooses the default --> stops run
mxrcx
commented
Jun 25, 2023
src/pyicu/callbacks/concept.py
Outdated
| if mode == "match_vals": | ||
| print(x) | ||
| print(x['po2']) | ||
| print(TableAccessor.is_id_tbl(x)) |
There was a problem hiding this comment.
is_ts_tbl() returns False, whereas is_id_tbl() returns an AttributeError: 'dict' object has no attribute 'is_pandas'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.