Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support "gen_tcp:connect" options #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fdie
Copy link
Contributor

@fdie fdie commented Nov 26, 2020

I believe some TCP settings should be configureable :

  • send_timeout : its default value "infinity" could be tricky
  • keepalive
  • sndbuf & recbuf : those sizes may have performance impacts

see https://erlang.org/doc/man/inet.html#setopts-2

NOTE: The SSLOpts variable in p1_mysql_conn may be renamed Opts or Options

  1. "proplists:get_bool(prop, Opts)" calls could be replace by "get_option(prop, Opts, false)" calls

  2. "get_option" works even if some properties are not keyvalues, for instance :

get_option(ssl_required, [keepalive, {send_timeout, 5000}, {ssl_required, true}], false).
true

@coveralls
Copy link

Coverage Status

Coverage remained the same at 0.0% when pulling e220c8b on fdie:gen_tcp_options into 31c30c9 on processone:master.

@Neustradamus
Copy link

@prefiks: Can you look?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants