Send alert messages on handshake failures #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When SSL_do_handshake() fails we should send data even when SSL_ERROR_WANT_WRITE is not reported (because a final error such as "unsupported protocol" is reported). If we don't do it, we don't send handshake alerts toward the peer and as a consequence: - We formally violate RFC 5246, appendix E.1: > If server supports (or is willing to use) only versions greater > than client_version, it MUST send a "protocol_version" alert message > and close the connection. - We are complicating the debugging of the protocol. - We don't give a hint to a peer on how to proceed with the error. This commit fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When SSL_do_handshake() fails we should send data even when SSL_ERROR_WANT_WRITE is not reported (because a final error such as "unsupported protocol" is reported).
If we don't do it, we don't send handshake alerts toward the peer and as a consequence:
This commit fixes it.