Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump dependencies in the rollup project #607

Merged
merged 10 commits into from
Oct 4, 2024

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented Sep 23, 2024

Bump rollup dependencies.
Don't update @types/node, prevent to have type errors as we are using an old typescript version (4.5).
Also switch from rimraf to del-cli, which is safer by default and provides more features.

Notes

del-cli: https://www.npmjs.com/package/del-cli

@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Sep 23, 2024
@tbouffard tbouffard added dependencies Pull requests that update a dependency file skip-changelog Do not include in Changelog and Release Notes javascript Pull requests that update Javascript code and removed chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) labels Sep 23, 2024
Copy link

github-actions bot commented Oct 4, 2024

🎊 PR Preview 035f1d2 has been successfully built and deployed to https://process-analytics-bpmn-visualization-examples-pr_preview-pr-607.surge.sh

🕐 Build time: 0.01s

🤖 By surge-preview

@tbouffard
Copy link
Member Author

Intermediate errors when not overriding the glob version

With some intermediate (releases available at a time that have received new updates afterwards) versions that were used during the developments of this PR, the glob dependency generated type errors.
At that time, an attempt to set/override the glob version as been tested, but it failed as well.
The usage of newer versions of some dependencies on 2024-10-04 fixed the issue: there is now no need to override the glob version.

Past errors, see https://github.com/process-analytics/bpmn-visualization-examples/actions/runs/10795028440/job/29940770804?pr=604

Error: node_modules/@types/glob/index.d.ts(29,42): error TS2694: Namespace '"/home/runner/work/bpmn-visualization-examples/bpmn-visualization-examples/projects/typescript-vanilla-with-rollup/node_modules/minimatch/dist/commonjs/index"' has no exported member 'IOptions'.
Error: node_modules/@types/glob/index.d.ts(74,30): error TS2724: '"/home/runner/work/bpmn-visualization-examples/bpmn-visualization-examples/projects/typescript-vanilla-with-rollup/node_modules/minimatch/dist/commonjs/index"' has no exported member named 'IMinimatch'. Did you mean 'Minimatch'?
Error: Process completed with exit code 2.

@tbouffard tbouffard marked this pull request as ready for review October 4, 2024 11:41
@tbouffard tbouffard merged commit 75e4a32 into master Oct 4, 2024
20 checks passed
@tbouffard tbouffard deleted the chore/rollup_project_bump_dependencies branch October 4, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code skip-changelog Do not include in Changelog and Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants