Skip to content

Commit

Permalink
move todo
Browse files Browse the repository at this point in the history
  • Loading branch information
tbouffard committed Sep 28, 2023
1 parent 9359ff9 commit ecd0fe5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/addons/src/bpmn-elements.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ const allBpmnElementKinds: BpmnElementKind[] = [...Object.values(ShapeBpmnElemen
* Options for deduplicating elements when several names match.
*/
export type ElementsSearcherFilterDuplicateOptions = {
// TODO decide if we decide to apply filter if there is a single elements?
kinds?: BpmnElementKind[];
// TODO find a better name
filter?: (bpmnSemantic: BpmnSemantic) => boolean;
Expand All @@ -50,6 +49,7 @@ export class BpmnElementsSearcher {
* @param name the name of the element to retrieve.
* @param options if not defined, or if the object doesn't define any properties, duplicates are filtered out by selecting the first element corresponding to the name provided.
*/
// TODO decide if we decide to apply filter if there is a single elements?
getElementByName(name: string, options?: ElementsSearcherFilterDuplicateOptions): BpmnSemantic | undefined {
// Not optimized, do a full lookup at each call
// Split query by kind to avoid returning a big chunk of data
Expand Down

0 comments on commit ecd0fe5

Please sign in to comment.