-
Notifications
You must be signed in to change notification settings - Fork 71
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* fix: show verbose ELF headers only in case of errors * style: Add spacing around concat operator * style: remove redundant parenthesis * fix: remove verbose logging to stdout elf sections * feat: add helper function to determine if File or Folder exists * feat: provide overwriteSecretFiles as an argument to function and remove flag dependency The overwritePtr flag was defined globally which created conflicts when calling functions within the setupsigning.go from other functions i.e not through the command line. Poroviding an boolean argument solves the problem * feat: add a new dependency 'cli' instead of 'flag' 'cli' is a better module which helps to make the command line interfaces more neater and well structured, both functionally as well as visually. this would help * users to understand the tool, as its style syncs with other popular cli * developers, very nice functional interface, best for programmers and new contributors who are not familiar with the flag command A pre-exisiting module, which is in its v2 is better than a self implemented command line parser / low level go module . * style: define constants globally * feat: provide options DeployOptions to pass build instructions from cli to functions * feat: restructure and rewrite appimagetool.go, use urfave/cli/v2 * chore: update go dependencies * fix: do not pass options through all functions instead declare a single options->DeployOptions in appimagetool.go prior to calling AppImageBuild() * docs: add documentation for functions * fix: use log.Fatal instead os.Write.StdErr as log.Fatal has built in Error handling and automatically exits with status 1 * style: explicitly ignore errors in removing and chmod'ing the file * fix: returned err variable was not received. The check was done for the previous step instead * style: use named arguments * fix: use lower case in appimagetool name in cli https://github.com/probonopd/go-appimage/issues/90\#issuecomment-720104568
- Loading branch information
1 parent
31b6a3f
commit 2fdd766
Showing
7 changed files
with
367 additions
and
224 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.