Move to AggregateFunctionExpr #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ggregateFunctionExpr struct
emgeee
reviewed
Sep 7, 2024
| @@ -55,4 +55,4 @@ serde_json = "1" | |||
| base64 = "0.22.1" | |||
| chrono = { version = "0.4.38", default-features = false } | |||
| itertools = "0.13" | |||
| pyo3 = { version = "0.21.2", features = ["experimental-async"] } | |||
| pyo3 = { version = "0.22.2", features = ["experimental-async"] } | |||
There was a problem hiding this comment.
did this dep need to be updated? I think datafusion-python currently requires pyo3 0.21
There was a problem hiding this comment.
yep. the latest DF depends on arrow 53.0.0, which needs a bump for pyo3
emgeee
reviewed
Sep 7, 2024
| @@ -225,7 +227,7 @@ impl StreamingWindowExec { | |||
| &input.schema(), | |||
| group_by.expr(), | |||
| &aggr_expr, | |||
| group_by.contains_null(), | |||
| false, //group_by.contains_null(), | |||
There was a problem hiding this comment.
what's up with this comment?
emgeee
reviewed
Sep 7, 2024
| @@ -10,7 +10,7 @@ name = "denormalized_python" | |||
| crate-type = ["cdylib"] | |||
|
|
|||
| [dependencies] | |||
| pyo3 = { version = "0.21.2", features = ["experimental-async"] } | |||
| pyo3 = { workspace = true } | |||
There was a problem hiding this comment.
did we need pyo3 out of the py-denormalized crate?
There was a problem hiding this comment.
yes we did. cargo update doesn't work otherwise because it goes down a circular resolver path.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.