Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Channels and Orchestration #35

Merged
merged 8 commits into from
Sep 6, 2024
Merged

Conversation

ameyc
Copy link
Contributor

@ameyc ameyc commented Sep 6, 2024

No description provided.

@ameyc ameyc requested a review from emgeee September 6, 2024 20:54
Cargo.toml Outdated Show resolved Hide resolved
/// An [`ExecutionPlan`] for one or more [`PartitionStream`]s.
///
/// If your source can be represented as one or more [`PartitionStream`]s, you can
/// use this struct to implement [`ExecutionPlan`].
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should add a comment/description as to why DenormalizedStreamingTableExec was created

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'll need to move in any operator which we want to add comms to/checkpoint. this will be true for join as well. more a larger design decision.

@ameyc ameyc merged commit a17a197 into main Sep 6, 2024
2 checks passed
@ameyc ameyc deleted the amey/adding-comms-orchestrator branch September 6, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants