Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a flag to ssm variables to resolve as string instead of object #1

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jeremygiberson
Copy link

@jeremygiberson jeremygiberson commented Mar 24, 2020

A PR to serverless https://github.com/serverless/serverless/pull/5842/files changed how ssm variables were resolved for secrets manager. If the content of the secret was a valid JSON string, then it was parsed and returned as a JSON object. This causes issues when trying to use the secret in an environment variable.

This PR extends the extended syntax for ssm variables to add a directive decryptAsPlaintext to skip the json parsing so that the plain text value is returned.

This branch was created from tag 1.51.0. (as that is the version we were using at the time).
TODO:

  • rebase from serverless/serverless master
  • fill out template below
  • make PR against serverless org

What did you implement

Closes #XXXXX

How can we verify it

Todos

Useful Scripts
  • npm run test:ci --> Run all validation checks on proposed changes
  • npm run lint:updated --> Lint all the updated files
  • npm run lint:fix --> Automatically fix lint problems (if possible)
  • npm run prettier-check:updated --> Check if updated files adhere to Prettier config
  • npm run prettify:updated --> Prettify all the updated files
  • Write and run all tests
  • Write documentation
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: NO
Is it a breaking change?: NO

Copy link
Author

@jeremygiberson jeremygiberson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bleep bloop, I'm a robot! In order to approve this pull request please submit a review with the following completed tasks.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants