Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collect_steps script #974

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

akoshelev
Copy link
Collaborator

PR #963 changed the root step name, now our script is failing.

Would be great to add it to CI, but I have high hopes that #961 is not too far ahead.

Tested by manually running this script

PR private-attribution#963 changed the root step name, now our script is failing.

Would be great to add it to CI, but I have high hopes that private-attribution#961 is not
too far ahead.

Tested by manually running this script
@akoshelev
Copy link
Collaborator Author

@eriktaubeneck this is probably the culprit for the issues you're dealing with

@eriktaubeneck eriktaubeneck self-requested a review March 15, 2024 21:37
Copy link
Member

@eriktaubeneck eriktaubeneck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

working for me!

@akoshelev akoshelev merged commit 4089860 into private-attribution:main Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants