Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore: remove leftover TODOs (new keyshare protocol) #337

Merged
merged 3 commits into from
Sep 4, 2023
Merged

Chore: remove leftover TODOs (new keyshare protocol) #337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3aadc2d
Chore: remove leftover TODOs
ivard Sep 1, 2023
926dd06
Chore: updated changelog
ivard Sep 1, 2023
a26449a
Chore: fix duplicate headers in changelog
ivard Sep 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## Unreleased

### Added
- E-mail address revalidation, addressing issues where user's e-mail addresses can be (temporary) invalid
- Keyshare server /api/v2/prove/... endpoints for the new keyshare protocol

### Changed
- Use separate application user in Dockerfile for entrypoint
Expand Down
1 change: 0 additions & 1 deletion internal/keysharecore/operations_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,6 @@ func TestProofFunctionality(t *testing.T) {
require.NoError(t, err)

// For issuance, initially get P_t
// TODO: The result ps will be used in the generate commitment step and checked when the response is made.
_, err = c.GeneratePs(secrets, jwtt, []irma.PublicKeyIdentifier{irma.PublicKeyIdentifier{Issuer: irma.NewIssuerIdentifier("test"), Counter: 1}})
require.NoError(t, err)

Expand Down
2 changes: 0 additions & 2 deletions server/keyshare/keyshareserver/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,6 @@ func (s *Server) handleCommitmentsV2(w http.ResponseWriter, r *http.Request) {
}

commitments, err := s.generateCommitmentsV2(user, authorization, req)
// TODO: can ErrInvalidChallenge be removed?
if err != nil && (err == keysharecore.ErrInvalidChallenge || err == keysharecore.ErrInvalidJWT) {
server.WriteError(w, server.ErrorInvalidRequest, err.Error())
return
Expand All @@ -338,7 +337,6 @@ func (s *Server) generateCommitmentsV2(user *User, authorization string, req irm
}

// Prepare output message format
// TODO: move logic to gabi?
mappedCommitments := map[irma.PublicKeyIdentifier]*big.Int{}
for i, keyID := range req.Keys {
mappedCommitments[keyID] = commitments[i].Pcommit
Expand Down