Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add index, dockerfile and github flow push docker image to ghcr #12

Merged
merged 7 commits into from
Nov 13, 2024
Merged

add index, dockerfile and github flow push docker image to ghcr #12

merged 7 commits into from
Nov 13, 2024

Conversation

saravahdatipour
Copy link
Contributor

@saravahdatipour saravahdatipour commented Nov 7, 2024 •
edited
Loading

add index, dockerfile and github flow push docker image to ghcr

@saravahdatipour saravahdatipour marked this pull request as draft November 8, 2024 09:40
@saravahdatipour saravahdatipour marked this pull request as ready for review November 8, 2024 09:49
DibranMulder
DibranMulder requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@DibranMulder DibranMulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please alter the README.MD like @ivard did in #8
Which commands do you use to startup this demo?

Also very nice that you added a status check which docker build. In the future we could add tests if needed.

DibranMulder
DibranMulder previously approved these changes Nov 12, 2024
View reviewed changes
@kamphuisem kamphuisem self-requested a review November 13, 2024 09:37
@w-ensink w-ensink merged commit f49927b into master Nov 13, 2024
1 check passed
@saravahdatipour saravahdatipour deleted the feature/irma-demos-container branch January 16, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w-ensink w-ensink w-ensink approved these changes

@kamphuisem kamphuisem kamphuisem approved these changes

@DibranMulder DibranMulder DibranMulder left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@saravahdatipour @kamphuisem @DibranMulder @w-ensink