-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New LeanIMT
incremental Merkle tree
#68
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xjei
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding job! I truly commend your approach in modularizing and generalizing the code to the fullest extent. The organization is both meticulous and efficient, to be honest :) I've noticed a few minor oversights in the sample READMEs, but overall, fantastic work! 🤩
0xjei
approved these changes
Nov 27, 2023
Rename `sparse-merkle-tree` package to `smt`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR moves the old
incremental-merkle-tree
library to the newimt
package, renaming classes and files, and adds a new incremental Merkle tree library (i.e.LeanIMT
), an optimized binary incremental Merkle tree.The libraries' code has been documented and tests have been reorganized to meet high-quality requirements.
Related Issue
Closes #67
Does this introduce a breaking change?
TODO
IMT
implementationincremental-merkle-tree.sol
toimt.sol
LeanIMT
Solidity implementation