Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(eddsa-poseidon): move poseidon-lite package to dependencies #345

Merged
merged 1 commit into from
Oct 15, 2024
Merged

build(eddsa-poseidon): move poseidon-lite package to dependencies #345

merged 1 commit into from
Oct 15, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Oct 15, 2024

Description

This PR moves the poseidon-lite package from dev dependencies to dependencies, in order to not include it in the final bundle.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have run yarn style without getting any errors
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@cedoor cedoor requested a review from vplasencia October 15, 2024 09:31
@cedoor cedoor merged commit f9d07ce into main Oct 15, 2024
2 checks passed
@cedoor cedoor deleted the build/poseidon-lite branch October 15, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vplasencia vplasencia vplasencia approved these changes

@artwyman artwyman Awaiting requested review from artwyman artwyman is a code owner

@sripwoud sripwoud Awaiting requested review from sripwoud sripwoud is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cedoor @vplasencia