Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New LeanIMT import/export methods #156

Merged
merged 1 commit into from
Feb 12, 2024
Merged

New LeanIMT import/export methods #156

merged 1 commit into from
Feb 12, 2024

Conversation

cedoor
Copy link
Member

@cedoor cedoor commented Feb 12, 2024

Description

This PR implements two new methods in the LeanIMT class: import and export. You can find more information in the related issue.

Related Issue(s)

Closes #155

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@cedoor cedoor requested a review from 0xjei February 12, 2024 10:37
Copy link
Member

@0xjei 0xjei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Just some nitpicks on test cases names but you can go ahead and merge. Great work!

packages/imt/tests/lean-imt.test.ts Show resolved Hide resolved
packages/imt/tests/lean-imt.test.ts Show resolved Hide resolved
packages/imt/tests/lean-imt.test.ts Show resolved Hide resolved
@cedoor
Copy link
Member Author

cedoor commented Feb 12, 2024

Awesome. Just some nitpicks on test cases names but you can go ahead and merge. Great work!

Thanks 🙏🏽 Test descriptions follow the same format as the others. I'd suggest opening a new issue for changing them since we would need to update many other descriptions.

@cedoor cedoor merged commit 971c6d5 into main Feb 12, 2024
2 checks passed
@cedoor cedoor deleted the feat/imt-export branch February 12, 2024 10:55
@0xjei
Copy link
Member

0xjei commented Feb 12, 2024

Awesome. Just some nitpicks on test cases names but you can go ahead and merge. Great work!

Thanks 🙏🏽 Test descriptions follow the same format as the others. I'd suggest opening a new issue for changing them since we would need to update many other descriptions.

Makes sense, tracked on #158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add import/export methods to the LeanIMT class
2 participants