Merge pull request #220 from privacy-scaling-explorations/fix/merkle-…

…proof-length Remove merkle proof length check in the `update` function
privacy-scaling-explorations · Mar 20, 2024 · 863415e · 863415e
2 parents b4c91e3 + 18b8ed9
commit 863415e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/packages/imt.sol/contracts/internal/InternalLeanIMT.sol b/packages/imt.sol/contracts/internal/InternalLeanIMT.sol
@@ -223,8 +223,6 @@ library InternalLeanIMT {
             revert LeafDoesNotExist();
         } else if (newLeaf != 0 && _has(self, newLeaf)) {
             revert LeafAlreadyExists();
-        } else if (siblingNodes.length == 0) {
-            revert WrongSiblingNodes();
         }
 
         uint256 index = _indexOf(self, oldLeaf);

diff --git a/packages/imt.sol/test/LeanIMT.ts b/packages/imt.sol/test/LeanIMT.ts
@@ -137,20 +137,22 @@ describe("LeanIMT", () => {
             await expect(transaction).to.be.revertedWithCustomError(leanIMT, "LeafGreaterThanSnarkScalarField")
         })
 
-        it("Should not update a leaf if there are no sibling nodes", async () => {
+        it("Should update a leaf if that's the only leaf in the tree", async () => {
             await leanIMTTest.insert(1)
 
             jsLeanIMT.insert(BigInt(1))
             jsLeanIMT.update(0, BigInt(2))
 
             const { siblings } = jsLeanIMT.generateProof(0)
 
-            const transaction = leanIMTTest.update(1, 2, siblings)
+            await leanIMTTest.update(1, 2, siblings)
 
-            await expect(transaction).to.be.revertedWithCustomError(leanIMT, "WrongSiblingNodes")
+            const root = await leanIMTTest.root()
+
+            expect(root).to.equal(jsLeanIMT.root)
         })
 
-        it("Should update a leaf", async () => {
+        it("Should update a leaf if there's more than 1 leaf in the tree", async () => {
             await leanIMTTest.insert(1)
             await leanIMTTest.insert(2)