Merge pull request #257 from privacy-scaling-explorations/fix/secret-…

…scalar Add mod reduction in secret scalar generation
privacy-scaling-explorations · Apr 23, 2024 · 82a90f5 · 82a90f5
2 parents 5ef9e74 + a8c6d3d
commit 82a90f5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/packages/eddsa-poseidon/src/eddsa-poseidon.ts b/packages/eddsa-poseidon/src/eddsa-poseidon.ts
@@ -53,7 +53,7 @@ export function deriveSecretScalar(privateKey: Buffer | Uint8Array | string): bi
     hash = hash.slice(0, 32)
     hash = pruneBuffer(hash)
 
-    return scalar.shiftRight(leBufferToBigInt(hash), BigInt(3))
+    return scalar.shiftRight(leBufferToBigInt(hash), BigInt(3)) % subOrder
 }
 
 /**