refactor(lean-imt): move from hardhat to forge
#23
Conversation
sripwoud
force-pushed
the
feat/forge
branch
4 times, most recently
from
e452eb4 to
21e444b
Compare
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
| @@ -134,51 +152,30 @@ jobs: | |||
| echo "matrix=$matrix" >> $GITHUB_OUTPUT | |||
|
|
|||
| slither: | |||
| if: needs.changed-files.outputs.any_changed == 'true' | |||
| needs: [changed-files, set-matrix, deps] | |||
| if: contains(needs.changed-files.outputs.modified_files, 'lean-imt') | |||
There was a problem hiding this comment.
somehow slither was buggy when the monorepo combines contracts that are compiled with either hardhat or forge. As slither in the ci is new, and because eventually we'll have only forge, I suggest restricting the ci check to the forge pkgs as a temp fix.
| "test:report-gas": "REPORT_GAS=true hardhat test", | ||
| "test:coverage": "hardhat coverage", | ||
| "typechain": "hardhat typechain", | ||
| "test:coverage": "forge coverage", |
There was a problem hiding this comment.
note that the current latest version of forge does not allow excluding the t.sol files from coverage.
This was fixed very recently foundry-rs/foundry#2988
There was a problem hiding this comment.
coverage is not 100%
especially I am not covering the WrongSiblingNodes revert: I could not figure out how to write a corresponding test 😅
sripwoud
added
tests 🧪
Towards #11
Closes #30
This PR replaces hardhat by forge in
lean-imtas solidity development framework:foudry.tomlonly specifies a remapping)soldeerfor solidity dependencies #25 is solved, solidity deps becomes git submodules (a bit worse dx imo)Note: sorry for the ugly commits history, I messed a rebase