Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate imt rust implementation from zk-kit to zk-kit.rs repo #5

Merged
merged 2 commits into from
Jul 12, 2024

Conversation

Arch0125
Copy link
Contributor

Description

This PR adds Rust implmentation of IMT with the following methods included insert/update/delete/create-proof/verify-proof

Related Issue

Closes #3

Does this introduce a breaking change?

  • Yes
  • No

Other information

Test coverage

  • Test New IMT Instance

    • Description: Ensure that a new IMT instance is created successfully.
  • Test Leaf Insertion

    • Description: Check if new leaves can be inserted into the tree.
  • Test Leaf Deletion

    • Description: Test the deletion functionality of a leaf in the tree.
  • Test Leaf Update

    • Description: Ensure that a leaf in the tree can be updated correctly.
  • Test Create and Verify Proof

    • Description: Create a Merkle proof for a leaf and verify its correctness.
  • Should Not Initialize with Too Many Leaves

    • Description: The tree should not initialize if the number of leaves exceeds arity ^ depth.
  • Should Not Insert in Full Tree

    • Description: Test that leaves cannot be inserted into a full tree.
  • Should Not Delete Nonexistent Leaf

    • Description: Ensure that attempting to delete a nonexistent leaf results in an error.

@Arch0125 Arch0125 requested review from cedoor and sripwoud as code owners July 12, 2024 06:46
@Arch0125
Copy link
Contributor Author

@cedoor lmk if this looks good

Copy link
Member

@sripwoud sripwoud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Thanks for migrating that crate to this repo

@sripwoud sripwoud merged commit 034cdce into privacy-scaling-explorations:main Jul 12, 2024
4 checks passed
@cedoor
Copy link
Member

cedoor commented Jul 12, 2024

Thanks both @Arch0125 for working on it and @sripwoud for reviewing it 🙏🏽

@Arch0125
Copy link
Contributor Author

Arch0125 commented Jul 12, 2024

@cedoor @sripwoud let me know what all implementations are needed to be added in the repo, would love to work it

@cedoor
Copy link
Member

cedoor commented Jul 12, 2024

@Arch0125 Created a new issue rn: #8. More will follow

@github-actions github-actions bot mentioned this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move IMT crate from zk-kit to zk-kit.rust
3 participants