Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cli): check if vkeys match #142

Closed
wants to merge 1 commit into from

Conversation

sripwoud
Copy link
Member

scripts/bin/test-cli-generate.bash

this

  • clones zk-kit.circom
  • generates the vkey for the poseidon-proof circuit
    • with circomkit
    • with the snark-artifacts CLI (generate command)
  • check if they match (diff)

Then don't match but I don't understand why

@sripwoud sripwoud requested a review from cedoor as a code owner September 11, 2024 12:58
Copy link

changeset-bot bot commented Sep 11, 2024

⚠️ No Changeset found

Latest commit: 6d372ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sripwoud sripwoud marked this pull request as draft September 11, 2024 13:00
@sripwoud
Copy link
Member Author

sripwoud commented Sep 11, 2024

hmm I think my test to check if the the validity of my verification key is fundamentally wrong.
The generated verification key depends on the accumulation of contributions and on randomness.

https://github.com/erhant/circomkit/blob/48bc6b91bb288cee5859c1a854772fe8fa95585b/src/core/index.ts#L369

So it is normal that 2 ceremonies, even if for the same circuit, generate different vkeys.

@sripwoud
Copy link
Member Author

Closed in favor of #143

@sripwoud sripwoud closed this Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant