Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add web page to query artifacts #105

Merged
merged 19 commits into from
Jun 26, 2024
Merged

feat: add web page to query artifacts #105

merged 19 commits into from
Jun 26, 2024

Conversation

sripwoud
Copy link
Member

@sripwoud sripwoud commented Jun 21, 2024 •
edited
Loading

Add web page (we can improve on the css styling later ^^) to use as s3 bucket main index.html to display at https://snark-artifacts.pse.dev

image

Close #99

Test:

pn --filter web dev, interact with the page to download artifacts

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4794756

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sripwoud sripwoud changed the title feat: add index page to private cdn feat: add web page to query artifacts Jun 24, 2024
@sripwoud sripwoud requested a review from cedoor June 24, 2024 11:33
@sripwoud sripwoud marked this pull request as ready for review June 24, 2024 11:33
@sripwoud sripwoud requested a review from ntampakas June 24, 2024 11:33
cedoor
cedoor approved these changes Jun 24, 2024
View reviewed changes
Copy link
Member

@cedoor cedoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

Should we add an option to download all the artifacts of a specific version?

apps/package.json Outdated Show resolved Hide resolved
@sripwoud sripwoud self-assigned this Jun 24, 2024
@sripwoud sripwoud added the enhancement New feature or request label Jun 24, 2024
@sripwoud
Copy link
Member Author

Great :)

Should we add an option to download all the artifacts of a specific version?

good idea.
Let s do that in a separate PR, see #107

ntampakas
ntampakas approved these changes Jun 26, 2024
View reviewed changes
Copy link
Contributor

@ntampakas ntampakas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sripwoud sripwoud merged commit ab082b4 into main Jun 26, 2024
1 check passed
@sripwoud sripwoud deleted the feat/index-html branch June 26, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cedoor cedoor cedoor approved these changes

@ntampakas ntampakas ntampakas approved these changes

Assignees

@sripwoud sripwoud

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a simple HTML page for snark-artifacts.pse.dev
3 participants
@sripwoud @ntampakas @cedoor