Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: update single round UI and slightly update the mobile UI #505

Merged
merged 1 commit into from
Dec 6, 2024
Merged

feat: update single round UI and slightly update the mobile UI #505

merged 1 commit into from
Dec 6, 2024

Conversation

kittybest
Copy link
Contributor

@kittybest kittybest commented Nov 28, 2024 •
edited
Loading

Description
Since there's need for only running single round, add the single round UI back but slightly modify the displayed information and alignment.

  • fix some mobile display issues
  • add Info component back on the main page while there's only 1 round
  • add view projects button no matter the user signed up or not
  • add view results button for user to quickly go the result page if the result is revealed
  • move the connect wallet button from top-right to the center of the page while it's mobile
  • better align the mentioned buttons
  • put back sign up button for single round

@vercel Vercel
Copy link

vercel bot commented Nov 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 6, 2024 4:49pm

@kittybest kittybest marked this pull request as ready for review November 29, 2024 18:09
0xmad
0xmad reviewed Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks, just left some comments

packages/interface/src/components/ConnectButton.tsx Outdated Show resolved Hide resolved
packages/interface/src/components/ConnectButton.tsx Outdated Show resolved Hide resolved
packages/interface/src/components/SingleRoundHome.tsx Outdated Show resolved Hide resolved
packages/interface/src/hooks/useIsMobile.ts Outdated Show resolved Hide resolved
packages/interface/src/pages/index.tsx Outdated Show resolved Hide resolved
0xmad
0xmad approved these changes Dec 5, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks!

@kittybest kittybest enabled auto-merge December 5, 2024 17:53
@ctrlc03 ctrlc03 disabled auto-merge December 6, 2024 14:29
@kittybest kittybest merged commit 5b130c4 into main Dec 6, 2024
17 checks passed
@kittybest kittybest deleted the feat/single-round branch December 6, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 left review comments

@0xmad 0xmad 0xmad approved these changes

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees

@kittybest kittybest

Labels
None yet
Projects
MACI Platform
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittybest @0xmad @ctrlc03