Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(merkleproof-gatekeeper): added support for the merkleproof gatekeeper #351

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

crisgarner
Copy link
Contributor

Adds support to the Merkle-proof gatekeeper.

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 30, 2024 11:37pm

@crisgarner
Copy link
Contributor Author

crisgarner commented Sep 20, 2024

Pending the release of the new version of the ci before merging.

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some comments

packages/interface/src/contexts/Maci.tsx Outdated Show resolved Hide resolved
packages/interface/src/env.js Show resolved Hide resolved
packages/interface/src/contexts/Maci.tsx Outdated Show resolved Hide resolved
@crisgarner crisgarner force-pushed the feat/merkleproof-gatekeeper branch 2 times, most recently from 5a625d0 to e43a8af Compare September 25, 2024 00:05
@crisgarner
Copy link
Contributor Author

Added recommendations 👍

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Sep 25, 2024

@crisgarner there's a workflow failing

@crisgarner
Copy link
Contributor Author

@crisgarner there's a workflow failing

Yes, didn't commit the dev ci library release as I understood it was temporal. Should I wait until it's ready or use the dev ci release?

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ctrlc03
Copy link
Collaborator

ctrlc03 commented Sep 30, 2024

@crisgarner there's a workflow failing

Yes, didn't commit the dev ci library release as I understood it was temporal. Should I wait until it's ready or use the dev ci release?

@crisgarner please use the CI release for now

@crisgarner crisgarner force-pushed the feat/merkleproof-gatekeeper branch from 58cc461 to 14f3310 Compare September 30, 2024 23:28
@crisgarner crisgarner merged commit d78fb04 into main Sep 30, 2024
16 checks passed
@crisgarner crisgarner deleted the feat/merkleproof-gatekeeper branch September 30, 2024 23:38
@crisgarner
Copy link
Contributor Author

crisgarner commented Sep 30, 2024

fixes #346

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants