chore: use strings for metadata on contracts #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctrlc03
requested review from
kittybest,
0xmad and
crisgarner
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ctrlc03
force-pushed
the
chore/strings-for-metadata
branch
from
6bd8c1a to
dbc7c2b
Compare
ctrlc03
force-pushed
the
chore/strings-for-metadata
branch
from
dbc7c2b to
e16a440
Compare
ctrlc03
force-pushed
the
chore/strings-for-metadata
branch
from
e16a440 to
e613253
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| function addRecipients(Recipient[] calldata recipients) external onlyOwner { | ||
| uint256 length = recipients.length; | ||
| /// @param _recipients The recipients | ||
| function addRecipients(Recipient[] calldata _recipients) external onlyOwner { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
kittybest
approved these changes
Sep 17, 2024
ctrlc03
force-pushed
the
chore/strings-for-metadata
branch
from
e613253 to
4ae7545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use strings for metadata pointers (note that strings in events to be indexed will be converted to its hash thus bytes32, hence why indexed was removed)
fix shadowing of recipients in EASRegistry