Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update info and ballot overview display #336

Merged
merged 1 commit into from
Sep 17, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 20 additions & 16 deletions packages/interface/src/components/BallotOverview.tsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import Link from "next/link";
import { useRouter } from "next/router";

import { Heading } from "~/components/ui/Heading";
import { useBallot } from "~/contexts/Ballot";
Expand All @@ -9,29 +8,34 @@ import { EAppState } from "~/utils/types";
import { AddedProjects } from "./AddedProjects";
import { VotingUsage } from "./VotingUsage";

export const BallotOverview = (): JSX.Element => {
interface IBallotOverviewProps {
title?: string;
}

export const BallotOverview = ({ title = undefined }: IBallotOverviewProps): JSX.Element => {
const { ballot } = useBallot();
const { asPath } = useRouter();

const appState = useAppState();

return (
<Link
href={
ballot.published && (appState === EAppState.TALLYING || appState === EAppState.RESULTS)
? "/ballot/confirmation"
: "/ballot"
}
>
<div className="dark:bg-lightBlack my-8 flex-col items-center gap-2 rounded-lg bg-white p-5 uppercase shadow-lg dark:text-white">
<Heading as="h3" size="3xl">
{asPath.includes("ballot") ? "Summary" : "My Ballot"}
</Heading>
<div className="w-full">
<Link
href={
ballot.published && (appState === EAppState.TALLYING || appState === EAppState.RESULTS)
? "/ballot/confirmation"
: "/ballot"
}
>
{title && (
<Heading as="h3" size="3xl">
{title}
</Heading>
)}

<AddedProjects />

<VotingUsage />
</div>
</Link>
</Link>
</div>
);
};
51 changes: 30 additions & 21 deletions packages/interface/src/components/Info.tsx
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { useRouter } from "next/router";
import { tv } from "tailwind-variants";

import { createComponent } from "~/components/ui";
Expand All @@ -6,6 +7,7 @@ import { useMaci } from "~/contexts/Maci";
import { useAppState } from "~/utils/state";
import { EInfoCardState, EAppState } from "~/utils/types";

import { BallotOverview } from "./BallotOverview";
import { InfoCard } from "./InfoCard";
import { RoundInfo } from "./RoundInfo";
import { VotingInfo } from "./VotingInfo";
Expand All @@ -25,12 +27,20 @@ const InfoContainer = createComponent(

interface InfoProps {
size: string;
showVotingInfo?: boolean;
showRoundInfo?: boolean;
showAppState?: boolean;
showBallot?: boolean;
}

export const Info = ({ size, showVotingInfo = false }: InfoProps): JSX.Element => {
export const Info = ({
size,
showRoundInfo = false,
showAppState = false,
showBallot = false,
}: InfoProps): JSX.Element => {
const { votingEndsAt } = useMaci();
const appState = useAppState();
const { asPath } = useRouter();

const steps = [
{
Expand Down Expand Up @@ -62,27 +72,26 @@ export const Info = ({ size, showVotingInfo = false }: InfoProps): JSX.Element =
return (
<div className="w-full">
<InfoContainer size={size}>
{showVotingInfo && (
<div className="w-full">
<RoundInfo />
{showRoundInfo && <RoundInfo />}

{appState === EAppState.VOTING && <VotingInfo />}
</div>
)}
{showBallot && <BallotOverview title={asPath.includes("ballot") ? "Summary" : undefined} />}

{steps.map(
(step) =>
step.start &&
step.end && (
<InfoCard
key={step.label}
end={step.end}
start={step.start}
state={defineState({ state: step.state, appState })}
title={step.label}
/>
),
)}
{showRoundInfo && appState === EAppState.VOTING && <VotingInfo />}

{showAppState &&
steps.map(
(step) =>
step.start &&
step.end && (
<InfoCard
key={step.label}
end={step.end}
start={step.start}
state={defineState({ state: step.state, appState })}
title={step.label}
/>
),
)}
</InfoContainer>
</div>
);
Expand Down
2 changes: 1 addition & 1 deletion packages/interface/src/components/VotingInfo.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export const VotingInfo = (): JSX.Element => {
}, 1000);

return (
<div className="py-4">
<div className="w-full py-4">
<h4 className="mb-2">Voting Ends In</h4>

{isLoading && <p>Loading...</p>}
Expand Down
10 changes: 6 additions & 4 deletions packages/interface/src/layouts/DefaultLayout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ import { GatekeeperTrait } from "maci-cli/sdk";
import { type ReactNode, type PropsWithChildren, useMemo } from "react";
import { useAccount } from "wagmi";

import { BallotOverview } from "~/components/BallotOverview";
import Header from "~/components/Header";
import { Info } from "~/components/Info";
import { Notice } from "~/components/ui/Notice";
Expand Down Expand Up @@ -102,9 +101,12 @@ export const LayoutWithSidebar = ({ ...props }: ILayoutProps): JSX.Element => {
sidebar="left"
sidebarComponent={
<div>
{showInfo && <Info showVotingInfo size="sm" />}

{appState !== EAppState.APPLICATION && showBallot && address && isRegistered && <BallotOverview />}
<Info
showAppState={showInfo}
showBallot={appState !== EAppState.APPLICATION && !!(showBallot && address && isRegistered)}
showRoundInfo={showInfo}
size="sm"
/>

{showSubmitButton && ballot.votes.length > 0 && (
<div className="flex flex-col gap-4">
Expand Down
2 changes: 1 addition & 1 deletion packages/interface/src/pages/signup/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const SignupPage = (): JSX.Element => {
{isConnected && !isRegistered && <JoinButton />}

<div className="my-8">
<Info size="default" />
<Info showAppState size="default" />
</div>
</div>

Expand Down
Loading