docs(contracts): add draft docs for contracts #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xmad
requested review from
ctrlc03,
kittybest and
crisgarner
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
- [x] Add script for uml generation - [x] Add docs for contracts with interaction and integration details
0xmad
force-pushed
the
docs/contracts
branch
from
842bbb3 to
65990ff
Compare
kittybest
reviewed
Sep 12, 2024
|
|
||
| #### Properties | ||
|
|
||
| - **easId**: `uint256` - Unique identifier for the EAS. |
There was a problem hiding this comment.
is this a certain EAS schema id? maybe it's better that we provide example of how should it be like here?
|
|
||
| #### Properties | ||
|
|
||
| - **contractId**: `uint256` - Unique identifier for the contract. |
There was a problem hiding this comment.
this should be the address of the EAS Registry contract, right? then I think we could specify it instead of just say it's a unique identifier for the contract?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #263