Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update gatekeeper, ballot callbacks and fix images for ballots #308

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: update gatekeeper, ballot callbacks and fix images for ballots #308

merged 1 commit into from
Sep 6, 2024

Conversation

crisgarner
Copy link
Contributor

  • Fix an issue where users aren't marked as valid to sign up if using Free For All Gatekeeper.
  • Fix an issue where application images are empty or the same if created with an empty or repeated recipient account.
  • Fix an issue where QV votes are not calculated correctly during the ballot.

@vercel Vercel
Copy link

vercel bot commented Sep 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 0:33am

ctrlc03
ctrlc03 approved these changes Sep 6, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@ctrlc03 ctrlc03 assigned ctrlc03 and crisgarner and unassigned ctrlc03 Sep 6, 2024
@ctrlc03 ctrlc03 merged commit bf37764 into main Sep 6, 2024
16 checks passed
@ctrlc03 ctrlc03 deleted the fix/ballot-and-free-for-all branch September 6, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@kittybest kittybest Awaiting requested review from kittybest kittybest is a code owner

@0xmad 0xmad Awaiting requested review from 0xmad 0xmad is a code owner

Assignees

@crisgarner crisgarner

Labels
None yet
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crisgarner @ctrlc03