Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): add registry integration #288

Merged
merged 1 commit into from
Aug 30, 2024
Merged

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Aug 28, 2024

  • Add deploy poll task
  • Add init poll task
  • Link registry and poll
  • Add deploy poll registry method for MACI

Related to #263

@0xmad 0xmad added the enhancement New feature or request label Aug 28, 2024
@0xmad 0xmad self-assigned this Aug 28, 2024
Copy link

vercel bot commented Aug 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 30, 2024 2:42pm

Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left some comments

packages/contracts/contracts/maci/MACI.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/maci/Poll.sol Outdated Show resolved Hide resolved
packages/contracts/contracts/maci/Poll.sol Outdated Show resolved Hide resolved
@0xmad 0xmad force-pushed the feature/registry-integration branch 2 times, most recently from 7c4531a to 4a1789a Compare August 29, 2024 18:25
- [x] Add deploy poll task
- [x] Add init poll task
- [x] Link registry and poll
- [x] Add deploy poll registry method for MACI
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff thanks

@0xmad 0xmad merged commit d6ce3ad into main Aug 30, 2024
16 checks passed
@0xmad 0xmad deleted the feature/registry-integration branch August 30, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants