-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts): add registry integration #288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
0xmad
force-pushed
the
feature/registry-integration
branch
from
August 28, 2024 20:23
e45857d
to
1698918
Compare
0xmad
force-pushed
the
feature/registry-integration
branch
from
August 28, 2024 20:36
1698918
to
c29b336
Compare
ctrlc03
reviewed
Aug 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, left some comments
0xmad
force-pushed
the
feature/registry-integration
branch
2 times, most recently
from
August 29, 2024 18:25
7c4531a
to
4a1789a
Compare
0xmad
force-pushed
the
feature/registry-integration
branch
from
August 29, 2024 18:39
4a1789a
to
f9e9288
Compare
0xmad
force-pushed
the
feature/registry-integration
branch
2 times, most recently
from
August 30, 2024 14:10
d0ba295
to
f88ea3c
Compare
0xmad
force-pushed
the
feature/registry-integration
branch
from
August 30, 2024 14:37
f88ea3c
to
2813daa
Compare
- [x] Add deploy poll task - [x] Add init poll task - [x] Link registry and poll - [x] Add deploy poll registry method for MACI
0xmad
force-pushed
the
feature/registry-integration
branch
from
August 30, 2024 14:38
2813daa
to
2fc0ae5
Compare
ctrlc03
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff thanks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #263