Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contracts): add registry manager #274

Merged
merged 1 commit into from
Aug 23, 2024
Merged

feat(contracts): add registry manager #274

merged 1 commit into from
Aug 23, 2024

Conversation

0xmad
Copy link
Collaborator

@0xmad 0xmad commented Aug 22, 2024

  • Add RegistryManager contract
  • Add EASRegistryManager contract
  • Add Common contract with common errors
  • Minor refactoring
  • Add tests

Related to #263

@0xmad 0xmad added the enhancement New feature or request label Aug 22, 2024
@0xmad 0xmad self-assigned this Aug 22, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 23, 2024 5:26pm

@0xmad 0xmad force-pushed the feature/approver branch 4 times, most recently from 2636f1a to 1377d82 Compare August 22, 2024 19:55
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 22, 2024
View reviewed changes
packages/contracts/contracts/mocks/MockRegistry.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/mocks/MockRegistry.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/mocks/MockRegistry.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/registry/EASRegistry.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/registry/EASRegistry.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/registryManager/EASRegistryManager.sol Dismissed Show dismissed Hide dismissed
packages/contracts/contracts/registryManager/EASRegistryManager.sol Fixed Show fixed Hide fixed
packages/contracts/contracts/registryManager/RegistryManager.sol Dismissed Show dismissed Hide dismissed
@0xmad 0xmad force-pushed the feature/approver branch from 1377d82 to dfd97f9 Compare August 22, 2024 20:03
@0xmad 0xmad force-pushed the feature/approver branch from dfd97f9 to 695c281 Compare August 22, 2024 20:43
@0xmad 0xmad force-pushed the feature/approver branch from 695c281 to d6a6b25 Compare August 22, 2024 21:29
@0xmad 0xmad force-pushed the feature/approver branch from d6a6b25 to 580281a Compare August 22, 2024 21:43
@0xmad 0xmad force-pushed the feature/approver branch from 580281a to 969aabd Compare August 23, 2024 15:49
@0xmad 0xmad marked this pull request as ready for review August 23, 2024 16:16
@0xmad 0xmad requested a review from ctrlc03 August 23, 2024 16:17
@0xmad 0xmad enabled auto-merge August 23, 2024 16:18
@kittybest
Copy link
Collaborator

Just a general question: why we need registry manager contract instead of writing those functions inside the registry contract?

@0xmad 0xmad force-pushed the feature/approver branch from 969aabd to 0e924cf Compare August 23, 2024 17:17
@0xmad
Copy link
Collaborator Author

0xmad commented Aug 23, 2024

Just a general question: why we need registry manager contract instead of writing those functions inside the registry contract?

Because we can have multiple registries and registry manager will be only one.
Plus, registry won't need to know about access control / request management logic.

@0xmad 0xmad force-pushed the feature/approver branch from 0e924cf to 44a8c75 Compare August 23, 2024 17:18
@0xmad
feat(contracts): add registry manager
c9ed506 
- [x] Add RegistryManager contract
- [x] Add EASRegistryManager contract
- [x] Add Common contract with common errors
- [x] Minor refactoring
- [x] Add tests
@0xmad 0xmad force-pushed the feature/approver branch from 44a8c75 to c9ed506 Compare August 23, 2024 17:21
ctrlc03
ctrlc03 approved these changes Aug 23, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks

@0xmad 0xmad merged commit 3b522c0 into main Aug 23, 2024
16 checks passed
@0xmad 0xmad deleted the feature/approver branch August 23, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@kittybest kittybest Awaiting requested review from kittybest kittybest is a code owner

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees

@0xmad 0xmad

Labels
enhancement New feature or request
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xmad @kittybest @ctrlc03