-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: session keys service #268
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ctrlc03
force-pushed
the
feat/session-key-service
branch
from
August 19, 2024 14:02
5bd700e
to
ec5d5fd
Compare
ctrlc03
force-pushed
the
feat/session-key-service
branch
from
August 19, 2024 21:19
ec5d5fd
to
67e8c3c
Compare
ctrlc03
force-pushed
the
feat/session-key-service
branch
from
August 20, 2024 14:35
67e8c3c
to
f8ece2c
Compare
0xmad
requested changes
Aug 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrlc03 thanks, there are some comments
packages/coordinator/ts/sessionKeys/__tests__/sessionKeys.service.test.ts
Outdated
Show resolved
Hide resolved
kittybest
reviewed
Aug 20, 2024
ctrlc03
force-pushed
the
feat/session-key-service
branch
from
August 21, 2024 14:42
f8ece2c
to
2629dfe
Compare
0xmad
reviewed
Aug 21, 2024
0xmad
reviewed
Aug 21, 2024
ctrlc03
force-pushed
the
feat/session-key-service
branch
from
August 22, 2024 08:13
2629dfe
to
3efd294
Compare
ctrlc03
force-pushed
the
feat/session-key-service
branch
2 times, most recently
from
August 23, 2024 17:12
601efbf
to
a752302
Compare
0xmad
reviewed
Aug 23, 2024
packages/coordinator/ts/sessionKeys/__tests__/sessionKeys.service.test.ts
Outdated
Show resolved
Hide resolved
packages/coordinator/ts/sessionKeys/__tests__/sessionKeys.service.test.ts
Outdated
Show resolved
Hide resolved
ctrlc03
force-pushed
the
feat/session-key-service
branch
from
August 23, 2024 17:37
a752302
to
d0d5b6f
Compare
ctrlc03
force-pushed
the
feat/session-key-service
branch
from
August 23, 2024 17:39
d0d5b6f
to
16b5fc2
Compare
0xmad
reviewed
Aug 23, 2024
ctrlc03
force-pushed
the
feat/session-key-service
branch
2 times, most recently
from
August 23, 2024 19:53
99775c7
to
d321a46
Compare
ctrlc03
force-pushed
the
feat/session-key-service
branch
from
August 23, 2024 20:15
d321a46
to
de158a4
Compare
0xmad
approved these changes
Aug 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ctrlc03 thanks!
ctrlc03
force-pushed
the
feat/session-key-service
branch
from
August 24, 2024 08:44
de158a4
to
d356de9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement a service to handle session keys generation and management
re: #266