Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary deps and env variables #257

Merged
merged 1 commit into from
Aug 13, 2024
Merged

chore: remove unnecessary deps and env variables #257

merged 1 commit into from
Aug 13, 2024

Conversation

ctrlc03
Copy link
Collaborator

@ctrlc03 ctrlc03 commented Aug 12, 2024 •
edited
Loading

  • remove skip voter check as we have FreeForAllGatekeeper instead
  • Remove unnecessary dependencies making the build time longer

@vercel Vercel
Copy link

vercel bot commented Aug 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-platform ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 13, 2024 6:27am

@ctrlc03 ctrlc03 self-assigned this Aug 12, 2024
0xmad
0xmad approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ctrlc03 thanks, just one minor suggestion.

packages/interface/package.json Show resolved Hide resolved
@ctrlc03 ctrlc03 enabled auto-merge August 12, 2024 21:17
@ctrlc03 ctrlc03 merged commit e0d15d5 into main Aug 13, 2024
13 checks passed
@ctrlc03 ctrlc03 deleted the chore/clean branch August 13, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad approved these changes

@kittybest kittybest Awaiting requested review from kittybest kittybest is a code owner

@crisgarner crisgarner Awaiting requested review from crisgarner crisgarner is a code owner

Assignees

@ctrlc03 ctrlc03

Labels
None yet
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctrlc03 @0xmad