Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wrongly display the round state #202

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

kittybest
Copy link
Contributor

Description
Before we used start time and end time of a certain state to decide whether it's passed, ongoing, or upcoming. However, since the poll sometimes deployed before the frontend started, the voting start time and end time is based on the contract, which caused more than one state could be under the ongoing state. This would be misleading users, changed to just follow the one and only appState by calling useAppState.

Copy link

vercel bot commented Jul 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-rpgf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 10, 2024 11:28am

@kittybest kittybest changed the title fix: sometimes wrongly display the round state fix: wrongly display the round state Jul 10, 2024
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@kittybest kittybest merged commit 682321a into feat/design-ui Jul 11, 2024
9 checks passed
@kittybest kittybest deleted the fix/info-display branch July 11, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants