Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate application page styling #194

Merged
merged 1 commit into from
Jul 12, 2024
Merged

feat: integrate application page styling #194

merged 1 commit into from
Jul 12, 2024

Conversation

kittybest
Copy link
Contributor

@kittybest kittybest commented Jul 1, 2024 •
edited
Loading

Description

  • Change pages styling
  • separate create application process to 2 steps
  • prevent heading for next step or submit if there's any unfilled required information
  • page for user to check their submitted application data
  • make sure approve application button works
  • finish styling of the /applications page

Out of this PR scope

  • reject application function and styling
  • edit application function and styling

@kittybest kittybest self-assigned this Jul 1, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-rpgf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 3:37pm

@kittybest kittybest force-pushed the feat/application-page branch from 3aec85a to 72050d5 Compare July 2, 2024 08:42
@kittybest kittybest force-pushed the feat/application-page branch from 72050d5 to 013337e Compare July 2, 2024 16:45
@kittybest kittybest force-pushed the feat/application-page branch from 013337e to 5fc8d8f Compare July 2, 2024 17:58
@kittybest kittybest force-pushed the feat/application-page branch from 5fc8d8f to fc3e271 Compare July 2, 2024 18:59
@kittybest kittybest force-pushed the feat/application-page branch from fc3e271 to a57c2c6 Compare July 3, 2024 12:12
@ctrlc03 ctrlc03 force-pushed the feat/application-page branch from a57c2c6 to 504cfc5 Compare July 3, 2024 14:15
@kittybest kittybest force-pushed the feat/application-page branch from 504cfc5 to 2889421 Compare July 3, 2024 14:27
@kittybest kittybest force-pushed the feat/application-page branch from 2889421 to 60fa548 Compare July 3, 2024 15:44
@kittybest kittybest force-pushed the feat/application-page branch from 60fa548 to 0bd63f4 Compare July 3, 2024 16:51
@kittybest kittybest force-pushed the feat/application-page branch from 0bd63f4 to 8a358d4 Compare July 3, 2024 18:21
@ctrlc03 ctrlc03 force-pushed the feat/application-page branch from 8a358d4 to dc705f2 Compare July 4, 2024 08:34
@kittybest kittybest force-pushed the feat/application-page branch from dc705f2 to e59db33 Compare July 4, 2024 10:09
@kittybest kittybest force-pushed the feat/application-page branch from e59db33 to 29dc5b0 Compare July 4, 2024 10:53
@kittybest kittybest force-pushed the feat/application-page branch from bee2517 to 6bdaa02 Compare July 9, 2024 18:17
@kittybest kittybest force-pushed the feat/application-page branch from 6bdaa02 to 411af58 Compare July 9, 2024 18:22
@kittybest kittybest marked this pull request as ready for review July 9, 2024 18:23
0xmad
0xmad requested changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks, just left some comments

src/features/applications/components/ApplicationButtons.tsx Outdated Show resolved Hide resolved
src/features/applications/components/ApplicationButtons.tsx Outdated Show resolved Hide resolved
src/features/applications/components/ApplicationButtons.tsx Outdated Show resolved Hide resolved
src/features/applications/components/ApplicationButtons.tsx Outdated Show resolved Hide resolved
src/features/applications/components/ReviewBar.tsx Outdated Show resolved Hide resolved
src/features/voters/components/VotersList.tsx Outdated Show resolved Hide resolved
src/pages/projects/[projectId]/Project.tsx Outdated Show resolved Hide resolved
@kittybest kittybest force-pushed the feat/application-page branch from 411af58 to ee3a85f Compare July 10, 2024 08:17
@kittybest kittybest force-pushed the feat/application-page branch from ee3a85f to 942c84e Compare July 10, 2024 14:28
@kittybest kittybest force-pushed the feat/application-page branch from 942c84e to 39a1077 Compare July 10, 2024 16:59
@kittybest kittybest force-pushed the feat/application-page branch from 39a1077 to 6295b61 Compare July 11, 2024 07:46
@kittybest kittybest mentioned this pull request Jul 12, 2024
Merged
@kittybest kittybest force-pushed the feat/application-page branch from 6295b61 to 1d6aae4 Compare July 12, 2024 15:35
0xmad
0xmad approved these changes Jul 12, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kittybest thanks!

@kittybest kittybest merged commit 4f96ab4 into feat/design-ui Jul 12, 2024
9 checks passed
@kittybest kittybest deleted the feat/application-page branch July 12, 2024 15:50
@kittybest kittybest mentioned this pull request Jul 17, 2024
Closed
@kittybest kittybest mentioned this pull request Aug 2, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad approved these changes

@ctrlc03 ctrlc03 Awaiting requested review from ctrlc03

@crisgarner crisgarner Awaiting requested review from crisgarner

Assignees

@kittybest kittybest

Labels
None yet
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kittybest @0xmad @ctrlc03