Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(env-docs): removed auth variables and improved docs #173

Merged
merged 2 commits into from
Jun 25, 2024
Merged

fix(env-docs): removed auth variables and improved docs #173

merged 2 commits into from
Jun 25, 2024

Conversation

crisgarner
Copy link
Contributor

  • Removed nextauth variables
  • Changed default values on env.example
  • Added video tutorial

@vercel Vercel
Copy link

vercel bot commented Jun 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
maci-rpgf ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 25, 2024 0:42am

kittybest
kittybest reviewed Jun 20, 2024
View reviewed changes
Copy link
Contributor

@kittybest kittybest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some of the env parts overlapped with this PR: #163

How do you think about combining the content of this 2 PR?

@crisgarner
Copy link
Contributor Author

I think some of the env parts overlapped with this PR: #163

How do you think about combining the content of this 2 PR?

I agree, this branch is more updated so will add the contents of #163 to this one

@crisgarner crisgarner mentioned this pull request Jun 20, 2024
Closed
@crisgarner
Copy link
Contributor Author

Added and improved #163

ctrlc03
ctrlc03 requested changes Jun 21, 2024
View reviewed changes
Copy link
Collaborator

@ctrlc03 ctrlc03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, left just a couple of comments

docs/01_setup.md Outdated Show resolved Hide resolved
docs/01_setup.md Outdated Show resolved Hide resolved
docs/01_setup.md Outdated Show resolved Hide resolved
docs/06_maci_troubleshooting.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
kittybest
kittybest reviewed Jun 21, 2024
View reviewed changes
docs/01_setup.md Outdated Show resolved Hide resolved
docs/01_setup.md Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the fix/default-config branch from c5f3a67 to fb80eda Compare June 24, 2024 08:54
@ctrlc03 ctrlc03 requested a review from 0xmad as a code owner June 24, 2024 08:54
@ctrlc03 ctrlc03 requested review from ctrlc03 and kittybest June 24, 2024 08:54
@ctrlc03 ctrlc03 force-pushed the fix/default-config branch from fb80eda to 9e096ab Compare June 24, 2024 09:03
0xmad
0xmad reviewed Jun 24, 2024
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
pnpm-lock.yaml Outdated Show resolved Hide resolved
public/mockServiceWorker.js Outdated Show resolved Hide resolved
@ctrlc03 ctrlc03 force-pushed the fix/default-config branch from 9e096ab to bb45b43 Compare June 24, 2024 14:56
@ctrlc03 ctrlc03 requested a review from 0xmad June 24, 2024 14:56
@ctrlc03 ctrlc03 force-pushed the fix/default-config branch from bb45b43 to 586ff41 Compare June 25, 2024 08:29
@ctrlc03 ctrlc03 force-pushed the fix/default-config branch from 586ff41 to 345f51e Compare June 25, 2024 09:11
@ctrlc03 ctrlc03 force-pushed the fix/default-config branch from 345f51e to 127e0a6 Compare June 25, 2024 12:39
0xmad
0xmad reviewed Jun 25, 2024
View reviewed changes
Copy link
Collaborator

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crisgarner @ctrlc03 thanks!

@ctrlc03 ctrlc03 merged commit c280402 into main Jun 25, 2024
10 checks passed
@ctrlc03 ctrlc03 deleted the fix/default-config branch June 25, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ctrlc03 ctrlc03 ctrlc03 approved these changes

@0xmad 0xmad 0xmad approved these changes

@kittybest kittybest Awaiting requested review from kittybest kittybest is a code owner

Assignees

@crisgarner crisgarner

Labels
None yet
Projects
MACI
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisgarner @kittybest @0xmad @ctrlc03