fix: stepComplete is still false if add contribution links or funding…

… source
privacy-scaling-explorations · Sep 2, 2024 · a1cecb9 · a1cecb9
1 parent 1542707
commit a1cecb9
Showing 1 changed file with 4 additions and 17 deletions.
diff --git a/packages/interface/src/features/applications/components/ApplicationButtons.tsx b/packages/interface/src/features/applications/components/ApplicationButtons.tsx
@@ -74,7 +74,7 @@ export const ApplicationButtons = ({
   ): boolean =>
     links === undefined || links.every((link) => link.description !== undefined && link.description.length > 0);
 
-  const stepComplete = useMemo((): boolean => {
+  const checkStepComplete = (): boolean => {
     if (step === EApplicationStep.PROFILE) {
       return (
         bannerImageUrl !== undefined &&
@@ -98,32 +98,19 @@ export const ApplicationButtons = ({
     }
 
     return true;
-  }, [
-    step,
-    bannerImageUrl,
-    profileImageUrl,
-    bio,
-    name,
-    payoutAddress,
-    websiteUrl,
-    impactCategory,
-    contributionDescription,
-    impactDescription,
-    contributionLinks,
-    fundingSources,
-  ]);
+  };
 
   const handleOnClickNextStep = useCallback(
     (event: UIEvent) => {
       event.preventDefault();
 
-      if (stepComplete) {
+      if (checkStepComplete()) {
         onNextStep();
       } else {
         setShowDialog(true);
       }
     },
-    [onNextStep, setShowDialog, stepComplete],
+    [onNextStep, setShowDialog, checkStepComplete],
   );
 
   const handleOnClickBackStep = useCallback(