Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nand and xor instructions #86

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Fix nand and xor instructions #86

merged 3 commits into from
Jan 26, 2024

Conversation

davidnevadoc
Copy link
Contributor

@davidnevadoc davidnevadoc commented Jan 25, 2024 •
edited
Loading

Description

Fixes the nand and xor instructions and add tests for them.
Closes #83

Changes

  • Add test for nand and xor.
  • Change nand so it returns the result.
  • Add missing constant in xor constraint.

@davidnevadoc davidnevadoc changed the title Nev@fix/logic ops Fix nand and xor instructions Jan 25, 2024
@davidnevadoc davidnevadoc marked this pull request as ready for review January 25, 2024 16:29
han0110
han0110 approved these changes Jan 26, 2024
View reviewed changes
Copy link
Contributor

@han0110 han0110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@davidnevadoc davidnevadoc merged commit 4e8e704 into master Jan 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@han0110 han0110 han0110 approved these changes

@kilic kilic Awaiting requested review from kilic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

maingate Instructions xor and nand are incorrect
2 participants
@davidnevadoc @han0110