Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix bug in div_unsafe #80

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Conversation

kitounliu
Copy link
Contributor

fix bug in div_unsafe: it should be sub not add for a

Copy link
Contributor

@davidnevadoc davidnevadoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes fix the bugs, thanks! LGTM

@davidnevadoc
Copy link
Contributor

davidnevadoc commented Sep 5, 2023

While looking into the assert_zero bug I also looked into assert_non_zero and I believe this line :

let a = &self.reduce_if_limb_values_exceeds_reduced(ctx, a)?;

could be removed because the reduction gets executed in the next call, here:
https://github.com/privacy-scaling-explorations/halo2wrong/blob/master/integer/src/chip/assert_not_zero.rs#L22

cc: @kilic

@kilic kilic merged commit 5233325 into privacy-scaling-explorations:master Sep 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants