-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Field generator macros #154
Field generator macros #154
Conversation
ce1512f
to
84edae1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finished first pass and left some comments.
Looking amazing so far :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Good job 🎉
Left some minor comments, but I think this can be merged.
Since it is such a big change, I wouldn't mind having an extra review though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice rework! Just left some small suggestions.
calculate extension field zeta in compile time bring back some removed comments
6abfdbb
This PR adds field generator macros and as a result removes many duplicates. There is an important breaking change that it now wraps all field representations for example as
ReprFq([u8; SIZE])
.Also it will help to add new fields and thus new curves. For example base field for BLS12-381 which has 6 limbs internal representation can be added as: