Skip to content

Complete create_proof refactor for fe-be split #250

Complete create_proof refactor for fe-be split

Complete create_proof refactor for fe-be split #250

GitHub Actions / Clippy (beta) succeeded Dec 14, 2023 in 0s

Clippy (beta)

22 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 22
Note 0
Help 0

Versions

  • rustc 1.66.0 (69f9c33d7 2022-12-12)
  • cargo 1.66.0 (d65d197ad 2022-11-15)
  • clippy 0.1.66 (69f9c33 2022-12-12)

Annotations

Check warning on line 358 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> halo2_proofs/src/plonk/prover.rs:358:21
    |
358 |                     &domain,
    |                     ^^^^^^^ help: change this to: `domain`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

Check warning on line 240 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this `if` has identical blocks

warning: this `if` has identical blocks
   --> halo2_proofs/src/plonk/prover.rs:237:55
    |
237 |               if column_indices.contains(&column_index) {
    |  _______________________________________________________^
238 | |                 // TODO: Check that column_index in witness is Some
239 | |                 // TODO: Check that the column length is `params.n()`
240 | |             } else {
    | |_____________^
    |
note: same as this
   --> halo2_proofs/src/plonk/prover.rs:240:20
    |
240 |               } else {
    |  ____________________^
241 | |                 // TODO: Check that column_index in witness is None
242 | |             };
    | |_____________^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
    = note: `-W clippy::if-same-then-else` implied by `-W clippy::all`

Check warning on line 1570 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

fields `num_fixed_columns` and `general_column_annotations` are never read

warning: fields `num_fixed_columns` and `general_column_annotations` are never read
    --> halo2_proofs/src/plonk/circuit.rs:1570:16
     |
1569 | pub struct ConstraintSystemV2Backend<F: Field> {
     |            ------------------------- fields in this struct
1570 |     pub(crate) num_fixed_columns: usize,
     |                ^^^^^^^^^^^^^^^^^
...
1609 |     pub(crate) general_column_annotations: HashMap<metadata::Column, String>,
     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: `ConstraintSystemV2Backend` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 51 in halo2_proofs/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

fields `fixed_commitments` and `permutation` are never read

warning: fields `fixed_commitments` and `permutation` are never read
  --> halo2_proofs/src/plonk.rs:51:5
   |
49 | pub struct VerifyingKeyV2<C: CurveAffine> {
   |            -------------- fields in this struct
50 |     domain: EvaluationDomain<C::Scalar>,
51 |     fixed_commitments: Vec<C>,
   |     ^^^^^^^^^^^^^^^^^
52 |     permutation: permutation::VerifyingKey<C>,
   |     ^^^^^^^^^^^
   |
   = note: `VerifyingKeyV2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

Check warning on line 236 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `advice_column`

warning: unused variable: `advice_column`
   --> halo2_proofs/src/plonk/prover.rs:236:28
    |
236 |         for (column_index, advice_column) in witness.iter().enumerate() {
    |                            ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_advice_column`

Check warning on line 90 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `rng`

warning: unused variable: `rng`
  --> halo2_proofs/src/plonk/prover.rs:90:9
   |
90 |         rng: R,
   |         ^^^ help: if this is intentional, prefix it with an underscore: `_rng`

Check warning on line 170 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `challenges`

warning: unused variable: `challenges`
   --> halo2_proofs/src/plonk/prover.rs:170:13
    |
170 |         let challenges = HashMap::<usize, Scheme::Scalar>::with_capacity(meta.num_challenges);
    |             ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_challenges`

Check warning on line 166 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `advice`

warning: unused variable: `advice`
   --> halo2_proofs/src/plonk/prover.rs:166:13
    |
166 |         let advice = AdviceSingle::<Scheme::Curve, LagrangeCoeff> {
    |             ^^^^^^ help: if this is intentional, prefix it with an underscore: `_advice`

Check warning on line 114 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `instance`

warning: unused variable: `instance`
   --> halo2_proofs/src/plonk/prover.rs:114:13
    |
114 |         let instance: InstanceSingle<Scheme::Curve> = {
    |             ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_instance`

Check warning on line 110 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `phases`

warning: unused variable: `phases`
   --> halo2_proofs/src/plonk/prover.rs:110:13
    |
110 |         let phases = circuit.cs.phases();
    |             ^^^^^^ help: if this is intentional, prefix it with an underscore: `_phases`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 773 in /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/core/src/macros/mod.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unreachable expression

warning: unreachable expression
   --> halo2_proofs/src/plonk/prover.rs:177:31
    |
176 |             advice_queries: todo!(),
    |                             ------- any code following this expression is unreachable
177 |             instance_queries: todo!(),
    |                               ^^^^^^^ unreachable expression
    |
    = note: `#[warn(unreachable_code)]` on by default
    = note: this warning originates in the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 358 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> halo2_proofs/src/plonk/prover.rs:358:21
    |
358 |                     &domain,
    |                     ^^^^^^^ help: change this to: `domain`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `-W clippy::needless-borrow` implied by `-W clippy::all`

Check warning on line 240 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

this `if` has identical blocks

warning: this `if` has identical blocks
   --> halo2_proofs/src/plonk/prover.rs:237:55
    |
237 |               if column_indices.contains(&column_index) {
    |  _______________________________________________________^
238 | |                 // TODO: Check that column_index in witness is Some
239 | |                 // TODO: Check that the column length is `params.n()`
240 | |             } else {
    | |_____________^
    |
note: same as this
   --> halo2_proofs/src/plonk/prover.rs:240:20
    |
240 |               } else {
    |  ____________________^
241 | |                 // TODO: Check that column_index in witness is None
242 | |             };
    | |_____________^
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
    = note: `-W clippy::if-same-then-else` implied by `-W clippy::all`

Check warning on line 1570 in halo2_proofs/src/plonk/circuit.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

fields `num_fixed_columns` and `general_column_annotations` are never read

warning: fields `num_fixed_columns` and `general_column_annotations` are never read
    --> halo2_proofs/src/plonk/circuit.rs:1570:16
     |
1569 | pub struct ConstraintSystemV2Backend<F: Field> {
     |            ------------------------- fields in this struct
1570 |     pub(crate) num_fixed_columns: usize,
     |                ^^^^^^^^^^^^^^^^^
...
1609 |     pub(crate) general_column_annotations: HashMap<metadata::Column, String>,
     |                ^^^^^^^^^^^^^^^^^^^^^^^^^^
     |
     = note: `ConstraintSystemV2Backend` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis

Check warning on line 51 in halo2_proofs/src/plonk.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

fields `fixed_commitments` and `permutation` are never read

warning: fields `fixed_commitments` and `permutation` are never read
  --> halo2_proofs/src/plonk.rs:51:5
   |
49 | pub struct VerifyingKeyV2<C: CurveAffine> {
   |            -------------- fields in this struct
50 |     domain: EvaluationDomain<C::Scalar>,
51 |     fixed_commitments: Vec<C>,
   |     ^^^^^^^^^^^^^^^^^
52 |     permutation: permutation::VerifyingKey<C>,
   |     ^^^^^^^^^^^
   |
   = note: `VerifyingKeyV2` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis
   = note: `#[warn(dead_code)]` on by default

Check warning on line 236 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `advice_column`

warning: unused variable: `advice_column`
   --> halo2_proofs/src/plonk/prover.rs:236:28
    |
236 |         for (column_index, advice_column) in witness.iter().enumerate() {
    |                            ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_advice_column`

Check warning on line 90 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `rng`

warning: unused variable: `rng`
  --> halo2_proofs/src/plonk/prover.rs:90:9
   |
90 |         rng: R,
   |         ^^^ help: if this is intentional, prefix it with an underscore: `_rng`

Check warning on line 170 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `challenges`

warning: unused variable: `challenges`
   --> halo2_proofs/src/plonk/prover.rs:170:13
    |
170 |         let challenges = HashMap::<usize, Scheme::Scalar>::with_capacity(meta.num_challenges);
    |             ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_challenges`

Check warning on line 166 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `advice`

warning: unused variable: `advice`
   --> halo2_proofs/src/plonk/prover.rs:166:13
    |
166 |         let advice = AdviceSingle::<Scheme::Curve, LagrangeCoeff> {
    |             ^^^^^^ help: if this is intentional, prefix it with an underscore: `_advice`

Check warning on line 114 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `instance`

warning: unused variable: `instance`
   --> halo2_proofs/src/plonk/prover.rs:114:13
    |
114 |         let instance: InstanceSingle<Scheme::Curve> = {
    |             ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_instance`

Check warning on line 110 in halo2_proofs/src/plonk/prover.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unused variable: `phases`

warning: unused variable: `phases`
   --> halo2_proofs/src/plonk/prover.rs:110:13
    |
110 |         let phases = circuit.cs.phases();
    |             ^^^^^^ help: if this is intentional, prefix it with an underscore: `_phases`
    |
    = note: `#[warn(unused_variables)]` on by default

Check warning on line 773 in /rustc/69f9c33d71c871fc16ac445211281c6e7a340943/library/core/src/macros/mod.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy (beta)

unreachable expression

warning: unreachable expression
   --> halo2_proofs/src/plonk/prover.rs:177:31
    |
176 |             advice_queries: todo!(),
    |                             ------- any code following this expression is unreachable
177 |             instance_queries: todo!(),
    |                               ^^^^^^^ unreachable expression
    |
    = note: `#[warn(unreachable_code)]` on by default
    = note: this warning originates in the macro `todo` (in Nightly builds, run with -Z macro-backtrace for more info)